Migrate to Base UI to fix Navbar hydration error#2182
Draft
hasparus wants to merge 7 commits intographql:sourcefrom
Draft
Migrate to Base UI to fix Navbar hydration error#2182hasparus wants to merge 7 commits intographql:sourcefrom
hasparus wants to merge 7 commits intographql:sourcefrom
Conversation
|
@hasparus is attempting to deploy a commit to the The GraphQL Foundation Team on Vercel. A member of the Team first needs to authorize it. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
saihaj
pushed a commit
that referenced
this pull request
Oct 24, 2025
## Description This PR adds a sidebar to the Tools and Libraries page, improves card styles (even heights, no jagged edges), makes the card footer neutral color (with a license icon for smaller screens instead of a word "license") and adds https://github.com/user-attachments/assets/57cb18bf-5894-4c4a-a28c-51c3a18f76c7 https://github.com/user-attachments/assets/d2c40fea-c2f2-4257-8513-5c2e06e53b6d ### Disclaimer This PR has a trade-off. I needed to get rid of Headless UI from the Navbar because the hydration error didn't let me code (like actually blocked the dev server from doing anything productive), so we end up in the state where we depend on a few components from Headless UI (also because of Nextra) and few components from Base UI. I got rid of the dependency on Radix RadioGroup so we end up with two headless component libraries like before, but eventually it would be great to use just one. To avoid making this PR larger I added Playwright tests to for the Headless UI-related components and started migrating them in #2182
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We need an event listener or a way to read open state to show the backdrop. Our current base components library Headless UI doesn't provide it, so we use a hacky workaround and set state from a render prop.
Moving out from Headless UI fixes it.